ACSS Swagger Changes in PUT SVI API and child resources #21604

dindurkhya · 2022-11-18T11:33:36Z

SAP Disk Customization
Add an optional property "Disk Configuration" in the PUT SVI payload. It will not break any existing customer flow as for existing customers this value is set to a default recommended configuration. For New VIS PUT calls, the user can choose to customize and provided changes.
Adding new property DiskConfigurationDetails in PUT SVI API input pay… by dindurkhya · Pull Request #9563 · Azure/azure-rest-api-specs-pr (github.com)

SAP Transport Fileshare Management
Add an optional property "StorageConfiguration" in InfrastructureConfiguration. The default behavior for when this property is not present is defined and it will continue to work for existing API/CLI clients if they do not make any changes to their payloads. It just adds new functionality for users who want to leverage it.
Swagger Changes for SAP Trans to 2021 Version by shreyks · Pull Request #9784 · Azure/azure-rest-api-specs-pr (github.com)

SAP LoadBalancer and Storage Details
Add an optional, read only property "LoadBalancerDetails" in SapCentralServerProperties, SapDatabaseProperties.
Add an Optional, read only property "StorageDetails" in CentralServerVmDetails, DatabaseVmDetails, SapApplicationServerProperties.
For Existing Sap Virtual Instances either these properties won't be present or will populated for relevant HA, Distributed type VISs.
Bmopati/LB and storage details changes for 2022-11-01 pr by bmopati · Pull Request #9464 · Azure/azure-rest-api-specs-pr (github.com)

Breaking Change Justification
The default behavior for when this property is not present is defined and it will continue to work for existing API/CLI clients if they do not make any changes to their payloads. It just adds new functionality for users who want to leverage it.

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

openapi-workflow-bot · 2022-11-18T11:33:40Z

Hi, @dindurkhya Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-11-18T11:33:41Z

Swagger Validation Report

️❌BreakingChange: 11 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
SAPVirtualInstance.json	2021-12-01-preview(a12a6d3)	2021-12-01-preview(main)

Rule	Message
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'storageDetails' in response that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2958:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2743:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'loadBalancerDetails' in response that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3395:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3153:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'storageDetails' in response that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2981:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2757:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'loadBalancerDetails' in response that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3481:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3234:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'storageDetails' in response that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3161:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2928:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'dbDiskConfiguration' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2395:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2306:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'diskConfiguration' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2449:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2356:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'storageConfiguration' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2619:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2428:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'storageDetails' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3161:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2928:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'loadBalancerDetails' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3395:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3153:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'loadBalancerDetails' that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3481:7 Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3234:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2021-12-01-preview	package-2021-12-01-preview(a12a6d3)	package-2021-12-01-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1797
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1935
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2157
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2161
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2799
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3550

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-18T11:33:42Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/workloads/armworkloads - 0.3.0

+	Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
+	Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
+	Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
+	Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
+	Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
+	Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
+	Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
+	Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 58f076e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-workloads [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model CentralServerVmDetails has a new parameter storage_details
info	[Changelog]   - Model DB2ProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model DB2ProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model DatabaseConfiguration has a new parameter disk_configuration
info	[Changelog]   - Model DatabaseVmDetails has a new parameter storage_details
info	[Changelog]   - Model HanaDbProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model HanaDbProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model Monitor has a new parameter storage_account_arm_id
info	[Changelog]   - Model Monitor has a new parameter zone_redundancy_preference
info	[Changelog]   - Model MsSqlServerProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model MsSqlServerProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model PrometheusHaClusterProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model PrometheusHaClusterProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model PrometheusOSProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model PrometheusOSProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model SAPApplicationServerInstance has a new parameter storage_details
info	[Changelog]   - Model SAPCentralServerInstance has a new parameter load_balancer_details
info	[Changelog]   - Model SAPDatabaseInstance has a new parameter load_balancer_details
info	[Changelog]   - Model SapNetWeaverProviderInstanceProperties has a new parameter ssl_certificate_uri
info	[Changelog]   - Model SapNetWeaverProviderInstanceProperties has a new parameter ssl_preference
info	[Changelog]   - Model SingleServerConfiguration has a new parameter db_disk_configuration
info	[Changelog]   - Model ThreeTierConfiguration has a new parameter storage_configuration

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 58f076e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-workloads [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 58f076e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/workloads/armworkloads [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ConfigurationTypeCreateAndMount`
info	[Changelog] - New const `ConfigurationTypeMount`
info	[Changelog] - New const `ConfigurationTypeSkip`
info	[Changelog] - New const `DiskSKUNamePremiumLRS`
info	[Changelog] - New const `DiskSKUNamePremiumV2LRS`
info	[Changelog] - New const `DiskSKUNamePremiumZRS`
info	[Changelog] - New const `DiskSKUNameStandardLRS`
info	[Changelog] - New const `DiskSKUNameStandardSSDLRS`
info	[Changelog] - New const `DiskSKUNameStandardSSDZRS`
info	[Changelog] - New const `DiskSKUNameUltraSSDLRS`
info	[Changelog] - New const `SAPSoftwareInstallationTypeExternal`
info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionFailed`
info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionInProgress`
info	[Changelog] - New const `SSLPreferenceDisabled`
info	[Changelog] - New const `SSLPreferenceRootCertificate`
info	[Changelog] - New const `SSLPreferenceServerCertificate`
info	[Changelog] - New type alias `ConfigurationType`
info	[Changelog] - New type alias `DiskSKUName`
info	[Changelog] - New type alias `SSLPreference`
info	[Changelog] - New function `*CreateAndMountFileShareConfiguration.GetFileShareConfiguration() *FileShareConfiguration`
info	[Changelog] - New function `*ExternalInstallationSoftwareConfiguration.GetSoftwareConfiguration() *SoftwareConfiguration`
info	[Changelog] - New function `*FileShareConfiguration.GetFileShareConfiguration() *FileShareConfiguration`
info	[Changelog] - New function `*MountFileShareConfiguration.GetFileShareConfiguration() *FileShareConfiguration`
info	[Changelog] - New function `PossibleConfigurationTypeValues() []ConfigurationType`
info	[Changelog] - New function `PossibleDiskSKUNameValues() []DiskSKUName`
info	[Changelog] - New function `PossibleSSLPreferenceValues() []SSLPreference`
info	[Changelog] - New function `*SkipFileShareConfiguration.GetFileShareConfiguration() *FileShareConfiguration`
info	[Changelog] - New struct `CreateAndMountFileShareConfiguration`
info	[Changelog] - New struct `DiskConfiguration`
info	[Changelog] - New struct `DiskSKU`
info	[Changelog] - New struct `DiskVolumeConfiguration`
info	[Changelog] - New struct `ExternalInstallationSoftwareConfiguration`
info	[Changelog] - New struct `FileShareConfiguration`
info	[Changelog] - New struct `LoadBalancerDetails`
info	[Changelog] - New struct `MountFileShareConfiguration`
info	[Changelog] - New struct `SkipFileShareConfiguration`
info	[Changelog] - New struct `StorageConfiguration`
info	[Changelog] - New struct `StorageInformation`
info	[Changelog] - New field `StorageDetails` in struct `CentralServerVMDetails`
info	[Changelog] - New field `SSLCertificateURI` in struct `DB2ProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `DB2ProviderInstanceProperties`
info	[Changelog] - New field `DiskConfiguration` in struct `DatabaseConfiguration`
info	[Changelog] - New field `StorageDetails` in struct `DatabaseVMDetails`
info	[Changelog] - New field `SSLCertificateURI` in struct `HanaDbProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `HanaDbProviderInstanceProperties`
info	[Changelog] - New field `StorageAccountArmID` in struct `MonitorProperties`
info	[Changelog] - New field `ZoneRedundancyPreference` in struct `MonitorProperties`
info	[Changelog] - New field `SSLCertificateURI` in struct `MsSQLServerProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `MsSQLServerProviderInstanceProperties`
info	[Changelog] - New field `SSLCertificateURI` in struct `PrometheusHaClusterProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `PrometheusHaClusterProviderInstanceProperties`
info	[Changelog] - New field `SSLCertificateURI` in struct `PrometheusOSProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `PrometheusOSProviderInstanceProperties`
info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `StorageDetails` in struct `SAPApplicationServerProperties`
info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `LoadBalancerDetails` in struct `SAPCentralServerProperties`
info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `LoadBalancerDetails` in struct `SAPDatabaseProperties`
info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientUpdateOptions`
info	[Changelog] - New field `SSLCertificateURI` in struct `SapNetWeaverProviderInstanceProperties`
info	[Changelog] - New field `SSLPreference` in struct `SapNetWeaverProviderInstanceProperties`
info	[Changelog] - New field `DbDiskConfiguration` in struct `SingleServerConfiguration`
info	[Changelog] - New field `StorageConfiguration` in struct `ThreeTierConfiguration`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 73 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 58f076e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-workloads [View full logs] [Release SDK Changes]

azure-arm-workloads-1.0.0-beta.3.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface CreateAndMountFileShareConfiguration
info	[Changelog]   - Added Interface DiskConfiguration
info	[Changelog]   - Added Interface DiskSku
info	[Changelog]   - Added Interface DiskVolumeConfiguration
info	[Changelog]   - Added Interface ExternalInstallationSoftwareConfiguration
info	[Changelog]   - Added Interface FileShareConfiguration
info	[Changelog]   - Added Interface LoadBalancerDetails
info	[Changelog]   - Added Interface MountFileShareConfiguration
info	[Changelog]   - Added Interface SkipFileShareConfiguration
info	[Changelog]   - Added Interface StorageConfiguration
info	[Changelog]   - Added Interface StorageInformation
info	[Changelog]   - Added Type Alias ConfigurationType
info	[Changelog]   - Added Type Alias DiskSkuName
info	[Changelog]   - Added Type Alias FileShareConfigurationUnion
info	[Changelog]   - Added Type Alias SslPreference
info	[Changelog]   - Interface CentralServerVmDetails has a new optional parameter storageDetails
info	[Changelog]   - Interface DatabaseConfiguration has a new optional parameter diskConfiguration
info	[Changelog]   - Interface DatabaseVmDetails has a new optional parameter storageDetails
info	[Changelog]   - Interface DB2ProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface DB2ProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface HanaDbProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface HanaDbProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface Monitor has a new optional parameter storageAccountArmId
info	[Changelog]   - Interface Monitor has a new optional parameter zoneRedundancyPreference
info	[Changelog]   - Interface MsSqlServerProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface MsSqlServerProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface PrometheusHaClusterProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface PrometheusHaClusterProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface PrometheusOSProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface PrometheusOSProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface SAPApplicationServerInstance has a new optional parameter storageDetails
info	[Changelog]   - Interface SAPCentralServerInstance has a new optional parameter loadBalancerDetails
info	[Changelog]   - Interface SAPDatabaseInstance has a new optional parameter loadBalancerDetails
info	[Changelog]   - Interface SapNetWeaverProviderInstanceProperties has a new optional parameter sslCertificateUri
info	[Changelog]   - Interface SapNetWeaverProviderInstanceProperties has a new optional parameter sslPreference
info	[Changelog]   - Interface SingleServerConfiguration has a new optional parameter dbDiskConfiguration
info	[Changelog]   - Interface ThreeTierConfiguration has a new optional parameter storageConfiguration
info	[Changelog]   - Added Enum KnownConfigurationType
info	[Changelog]   - Added Enum KnownDiskSkuName
info	[Changelog]   - Added Enum KnownSslPreference
info	[Changelog]   - Enum KnownSAPSoftwareInstallationType has a new value External
info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionFailed
info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionInProgress

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 58f076e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Workloads [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Workloads.1.0.0-alpha.20221128.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 58f076e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️workloads [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-18T11:33:43Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/workloads/armworkloads	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-workloads	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-workloads	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Workloads	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-workloads	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-11-18T11:39:44Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

…)" This reverts commit 58f076e.

…esources (#2676) Create to sync Azure/azure-rest-api-specs#21604 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/workloads?expand=1)

…)" (#21662) This reverts commit 58f076e.

…es (#21604)" (#21662)" This reverts commit 495363b.

…es (#21604)" (#21662)" (#21663) This reverts commit 495363b.

@shreyas

* @shreyas : SAP Trans Changes for Swagger * @Divyani: SAP Disk Customization - Adding DiskConfiguration in PUTSVI * @bharath: Adding LB, Storage details to child resources

…e#21604)" (Azure#21662) This reverts commit 58f076e.

…es (Azure#21604)" (Azure#21662)" (Azure#21663) This reverts commit 495363b.

@shreyas

* @shreyas : SAP Trans Changes for Swagger * @Divyani: SAP Disk Customization - Adding DiskConfiguration in PUTSVI * @bharath: Adding LB, Storage details to child resources

…e#21604)" (Azure#21662) This reverts commit 58f076e.

…es (Azure#21604)" (Azure#21662)" (Azure#21663) This reverts commit 495363b.

@shreyas : SAP Trans Changes for Swagger

c4af632

openapi-assignment-bot bot assigned honghr Nov 18, 2022

AzureRestAPISpecReview added NewApiVersionRequired resource-manager RPaaS labels Nov 18, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 18, 2022

dindurkhya added 2 commits November 18, 2022 17:16

@Divyani: SAP Disk Customization - Adding DiskConfiguration in PUTSVI

35a8c04

@bharath: Adding LB, Storage details to child resources

a12a6d3

gargankit-microsoft added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 18, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 22, 2022

gargankit-microsoft approved these changes Nov 23, 2022

View reviewed changes

honghr added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Nov 24, 2022

honghr approved these changes Nov 24, 2022

View reviewed changes

honghr removed the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Nov 24, 2022

ruowan merged commit 58f076e into Azure:main Nov 28, 2022

ruowan added a commit that referenced this pull request Nov 28, 2022

Revert "ACSS Swagger Changes in PUT SVI API and child resources (#21604…

fa9cde1

…)" This reverts commit 58f076e.

ruowan mentioned this pull request Nov 28, 2022

Revert "ACSS Swagger Changes in PUT SVI API and child resources" #21662

Merged

azure-sdk mentioned this pull request Nov 28, 2022

[ReleasePR @azure/arm-workloads] [Microsoft.Workloads/monitors] Add a new API version 2023-10-01-preview Azure/azure-sdk-for-js#21876

Closed

ruowan added a commit that referenced this pull request Nov 28, 2022

Revert "ACSS Swagger Changes in PUT SVI API and child resources (#21604…

495363b

…)" (#21662) This reverts commit 58f076e.

ruowan added a commit that referenced this pull request Nov 28, 2022

Revert "Revert "ACSS Swagger Changes in PUT SVI API and child resourc…

e2161e9

…es (#21604)" (#21662)" This reverts commit 495363b.

ruowan mentioned this pull request Nov 28, 2022

ACSS Swagger Changes in PUT SVI API and child resources"" #21663

Merged

ruowan added a commit that referenced this pull request Dec 5, 2022

Revert "Revert "ACSS Swagger Changes in PUT SVI API and child resourc…

5dedb96

…es (#21604)" (#21662)" (#21663) This reverts commit 495363b.

anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022

Revert "ACSS Swagger Changes in PUT SVI API and child resources (Azur…

3dd1ad5

…e#21604)" (Azure#21662) This reverts commit 58f076e.

anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022

Revert "Revert "ACSS Swagger Changes in PUT SVI API and child resourc…

de7ce0a

…es (Azure#21604)" (Azure#21662)" (Azure#21663) This reverts commit 495363b.

kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022

Revert "ACSS Swagger Changes in PUT SVI API and child resources (Azur…

750ff25

…e#21604)" (Azure#21662) This reverts commit 58f076e.

kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022

Revert "Revert "ACSS Swagger Changes in PUT SVI API and child resourc…

807ff5b

…es (Azure#21604)" (Azure#21662)" (Azure#21663) This reverts commit 495363b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACSS Swagger Changes in PUT SVI API and child resources #21604

ACSS Swagger Changes in PUT SVI API and child resources #21604

dindurkhya commented Nov 18, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 18, 2022

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 18, 2022

ACSS Swagger Changes in PUT SVI API and child resources #21604

ACSS Swagger Changes in PUT SVI API and child resources #21604

Conversation

dindurkhya commented Nov 18, 2022 • edited Loading

openapi-workflow-bot bot commented Nov 18, 2022

openapi-pipeline-app bot commented Nov 18, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 18, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 18, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Nov 18, 2022

dindurkhya commented Nov 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 18, 2022 •

edited

Loading